Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav scrolling does not appear for nested tab groups #815

Closed
dcx opened this issue Jul 4, 2022 · 2 comments
Closed

Nav scrolling does not appear for nested tab groups #815

dcx opened this issue Jul 4, 2022 · 2 comments
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@dcx
Copy link

dcx commented Jul 4, 2022 •
edited
Loading

Describe the bug

When you add an (inner) tab group into the tab panel of an (outer) tab group, nav scrolling doesn't seem to activate on the inner tab group.

To Reproduce

https://codepen.io/dchx/pen/GRxpmqE

Screenshots

shoelace-screenshot

Additional information

At first glance this seemed similar to #620, but I felt the underlying issue might be different enough to warrant separate tracking.

I'm new to shoelace and have been loving it so far, by the way;
thanks for creating this fantastic project!
@dcx dcx added the bug Things that aren't working right in the library. label Jul 4, 2022
@claviska
Copy link
Member

Apologies for the delay. This was tricky to track down, but the fix was simple. Nested tab panels are working as expected now.

CleanShot 2022-07-19 at 09 31 44

@dcx
Copy link
Author

dcx commented Jul 26, 2022

Amazing job, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @dcx