Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Submit Controller Import is not found in dist #886

Closed
austinzhang1018 opened this issue Aug 29, 2022 · 1 comment
Closed

Form Submit Controller Import is not found in dist #886

austinzhang1018 opened this issue Aug 29, 2022 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@austinzhang1018
Copy link

austinzhang1018 commented Aug 29, 2022

Describe the bug

In /dist/components/radio-group/radio-group.d.ts, the FormSubmitController is imported from src/internal/form instead of the correct relative path ../../internal/form.

This is causing a typescript compilation error when used in typescript projects

node_modules/@shoelace-style/shoelace/dist/components/radio-group/radio-group.d.ts(1,38): error TS2307: Cannot find module 'src/internal/form' or its corresponding type declarations.

To Reproduce

  1. Build the project
  2. Open the radio-group.d.ts file has an import from the src directory
@austinzhang1018 austinzhang1018 added the bug Things that aren't working right in the library. label Aug 29, 2022
@claviska
Copy link
Member

Thanks for reporting this. I found a few other paths that were being imported the same way and updated them all in 3a6890. These changes will be available in the next beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants