Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking validity of sl-radio-group #992

Closed
claviska opened this issue Nov 2, 2022 Discussed in #987 · 1 comment
Closed

Checking validity of sl-radio-group #992

claviska opened this issue Nov 2, 2022 Discussed in #987 · 1 comment
Labels
bug Things that aren't working right in the library.

Comments

@claviska
Copy link
Member

claviska commented Nov 2, 2022

Discussed in #987

Originally posted by nickcipriani October 29, 2022
I'm having trouble checking the validity of an sl-radio-group. Here it is in the code share: https://lit.dev/playground/#gist=b2b8aa7b8de22b71bccbdabe176640ed

Even when no radio option is selected, the validity comes back true when checking for the invalid attribute on the group. The group has the required property so it should not be valid. Is there something I'm missing?

@claviska claviska added the bug Things that aren't working right in the library. label Nov 7, 2022
@claviska claviska added this to the v2.0.0 release milestone Nov 8, 2022
@claviska
Copy link
Member Author

claviska commented Nov 9, 2022

Looks like validity was initially incorrect when using required, and it also looks like it was getting out of sync as options were selected. This has been fixed in f140007 and two tests were added to prevent regressions. This fix will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

1 participant