Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to apply styling to button icon #999

Closed
ChristopherHawkes opened this issue Nov 7, 2022 · 2 comments
Closed

Unable to apply styling to button icon #999

ChristopherHawkes opened this issue Nov 7, 2022 · 2 comments
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@ChristopherHawkes
Copy link

Describe the bug

I see no way of being able to customize the color of the button which is rendered via sl-icon-button which renders a nested sl-icon

Demo

image
@ChristopherHawkes ChristopherHawkes added the bug Things that aren't working right in the library. label Nov 7, 2022
@ChristopherHawkes
Copy link
Author

My fault, looks like I need to do something like this.

image

@claviska
Copy link
Member

claviska commented Nov 8, 2022

Styling the base part works, but it's not very ergonomic. I've improved this in 49193c9 so you can apply color directly to sl-icon-button and I've added tests to ensure both color and font-size will inherit correctly moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @ChristopherHawkes