Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples works but not completely #23

Closed
ashbb opened this issue May 28, 2012 · 5 comments
Closed

Samples works but not completely #23

ashbb opened this issue May 28, 2012 · 5 comments

Comments

@ashbb
Copy link
Member

ashbb commented May 28, 2012

The following four samples works on my Windows 7 with the latest commit ffa0b33.

simple-animate.rb
simple-move.rb
simple-sound.rb
simple-stripes.rb

But looks like not completely for now. ;-)

  • the window is not resizable
  • the window's background color is not white
  • the window's size is not correct (default should be 600 x 500)
  • no icon on the window (Note: Windows only)
@wasnotrice
Copy link
Member

This is great on two counts:

  1. Everything that should work on Windows does!
  2. We have a list of features we need to add to Shoes4

Thanks @ashbb!

@wasnotrice
Copy link
Member

@ashbb on my Shoes 3, the window's background color is not white, it is #ededed. In Shoes4, it is not the same, but very similar: #e9e9e9

Shoes 3:

Shoes 4:

$ bin/swt-shoooes samples/simple-animate.rb

Is it different for you?

@ashbb
Copy link
Member Author

ashbb commented May 30, 2012

Oops, I don't know anything except Windows...
Look at line 1150 in windows.c of Shoes 3.
Default background color (brush) is WHITE_BRUSH.

@wasnotrice
Copy link
Member

Another bug discovered! It doesn't matter to me what color it is, but white seems like a good default. Let's make Shoes 4 default to white background on all platforms!

@wasnotrice
Copy link
Member

I've created separate issues for each of the bugs noted here. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants