Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any set orientation is overridden when RTMP publishing begins #43

Closed
aaronzufall opened this issue May 23, 2016 · 0 comments
Closed

Any set orientation is overridden when RTMP publishing begins #43

aaronzufall opened this issue May 23, 2016 · 0 comments

Comments

@aaronzufall
Copy link

aaronzufall commented May 23, 2016

If I set any orientation before broadcasting using rtmpStream.captureSettings["orientation"], that value is overridden when stream publishing starts. I've found that this is due to lines 409-411 in AVMixer.swift:

if let orientation:AVCaptureVideoOrientation = AVMixer.getAVCaptureVideoOrientation(UIDevice.currentDevice().orientation) {
     self.orientation = orientation
}

These lines should either be removed, or something should check if an orientation was set through captureSettings. (Pull request)

shogo4405 added a commit that referenced this issue May 23, 2016
PhilipDukhov pushed a commit to PhilipDukhov/HaishinKit.swift that referenced this issue Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants