Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to disable error message in raw logs #1302

Closed
sidey79 opened this issue Oct 19, 2022 · 1 comment · Fixed by #1326
Closed

Want to disable error message in raw logs #1302

sidey79 opened this issue Oct 19, 2022 · 1 comment · Fixed by #1326

Comments

@sidey79
Copy link

sidey79 commented Oct 19, 2022

I found out that if i use this awesom action, somethin happens with my error output.

That is something i wasn't aware of it and now i try to prevent this happening.

Overall, i run serval tests with prove. Now i want to pipe the results over to reviewdog/reviewdog to generate nice inline comments at the right place.

If i run prove without using actions-setup-perl on github actions anything looks as on my local machine.
Output is as expected from prove.
No [Error] statement can be found in the raw log. This is my expected behaivor also using this action: job details

    # Failed test 'check returnvalue Hello_Define'
    # at /home/runner/work/perlTest/perlTest/t/FHEM/98_HELLO/00_define.t line 21.
    # +---------+-----------+---------+-----+
    # | GOT     | OP        | CHECK   | LNs |
    # +---------+-----------+---------+-----+
    # | <UNDEF> | DEFINED() | DEFINED | 21  |
    # +---------+-----------+---------+-----+

# Failed test 'Demo Test checking define'
# at /home/runner/work/perlTest/perlTest/t/FHEM/98_HELLO/00_define.t line [22]

If i use the actions-setup-perl
There are additional Error: Statements in the log. Even in the raw log. job details

    # Failed test 'check returnvalue Hello_Define'
Error:     # at /home/runner/work/perlTest/perlTest/t/FHEM/98_HELLO/00_define.t line 21.
    # +---------+-----------+---------+-----+
    # | GOT     | OP        | CHECK   | LNs |
    # +---------+-----------+---------+-----+
    # | <UNDEF> | DEFINED() | DEFINED | 21  |
    # +---------+-----------+---------+-----+

# Failed test 'Demo Test checking define'
Error: # at /home/runner/work/perlTest/perlTest/t/FHEM/98_HELLO/00_define.t line 22.
/home/runner/work/perlTest/perlTest/t/FHEM/98_HELLO/00_define.t .. 

I also tryed to disable workflow commands for this command as explained in the github docs:

        stopMarker=$(uuidgen)
        echo "::stop-commands::$stopMarker"
        prove --exec 'perl -MDevel::Cover=-silent,1 fhem.pl -t' -I FHEM -r -vv ${GITHUB_WORKSPACE}/t/FHEM/[0-9][0-9]_*/
        echo "::$stopMarker::"

But this doesn't help.

Am i right, that this output is caused by your action? Any ideas how i can disable them?

@sidey79
Copy link
Author

sidey79 commented Oct 20, 2022

Today i took a fresh look onto this.

I figured out, that this seems to come from the problem matcher, which can be disabled:

    echo "::remove-matcher owner=perl::"

May you can to add this to the docs or add a conditional switch to enable / disable the problem matcher overall?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant