Exceeding array bounds in SGVector::arg_max(vec, inc, len, ptr), SGVector.cpp, Line 995

[tklein23]

Simply add an assertion to enforce array bounds to the loop:

ASSERT(j < len)

This should never happen, but will break two unit tests.

[tklein23]

Failing tests are: mMCLDA.train_and_apply and mQDA.train_and_apply

[karlnapf]

Thanks for reporting! Ouch! We should probably just rewrite this method in a proper (and in fact readable) way

[tklein23]

Soeren told, that this method is correct. So the only issue is documentation and/or readability.

My assumption was (j < len), but as far as I see, this was wrong.

[karlnapf]

@sonney2k Could you document this method?