Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGMatrix<T>::compute_eigenvectors needs facelift #2000

Open
karlnapf opened this issue Mar 14, 2014 · 0 comments
Open

SGMatrix<T>::compute_eigenvectors needs facelift #2000

karlnapf opened this issue Mar 14, 2014 · 0 comments

Comments

@karlnapf
Copy link
Member

It assumes matrix is PSD. It outputs non-readable lapack error codes. It is impossible to read (without a degree in lapack), it is in the wrong place in Shogun (should be Math/linalg)

This should be removed and solved via #1930 and offer different modes: self-adjoint, and different ways that are more stable, such as SVD. Different tolerance levels, it should be able to deal with errors (such as first trying self-adjoint and if that doesnt work use another one, or add a number to the diagonal, etcetc)

@karlnapf karlnapf changed the title SGMatrix<T>::compute_eigenvectors is completely stupid SGMatrix<T>::compute_eigenvectors needs facelift Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant