Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for CHMM #2713

Open
karlnapf opened this issue Feb 16, 2015 · 7 comments
Open

Write unit tests for CHMM #2713

karlnapf opened this issue Feb 16, 2015 · 7 comments

Comments

@karlnapf
Copy link
Member

Systematically unit-test all methods of CHMM.
In particular, use the existing examples (modular AND static) and transform them into unit-tests.

We will need this to ensure that results do not change when we refactor.

@avramidis
Copy link
Contributor

Hello @karlnapf
Is this issue still valid? I checked for CHMM unit test and could not find. If it's ok with you I would like to work on this.
Thanks

@karlnapf
Copy link
Member Author

karlnapf commented Nov 8, 2018

The issue is still open, yes, and the file/class is still in the source tree.

@avramidis
Copy link
Contributor

Great, thanks!

@MaxGreil
Copy link
Contributor

MaxGreil commented Aug 6, 2019

@karlnapf is this issue still open?

@karlnapf
Copy link
Member Author

karlnapf commented Aug 7, 2019

as you will see when checking the unit test directory, there are not tests for HMM, yes :)

@MaxGreil
Copy link
Contributor

MaxGreil commented Aug 8, 2019

@karlnapf I have an additional question:
I found the existing modular example for HMM under https://github.com/shogun-toolbox/shogun/blob/a5926c3363440a36bab796b4162f2a0dd6699dd3/examples/descriptions/modular/distribution_hmm.txt but I could not find the static example for HMM. Can you please tell me where I can find it?

@karlnapf
Copy link
Member Author

shogun/examples/undocumented/python/distribution_hmm.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants