Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Combined and String features in trees #3626

Open
vigsterkr opened this issue Feb 15, 2017 · 4 comments
Open

Support for Combined and String features in trees #3626

vigsterkr opened this issue Feb 15, 2017 · 4 comments

Comments

@vigsterkr
Copy link
Member

Currently all the tree implementations, C4.5, CHAID, CART, requires the input feature to be in CDenseFeatures<float64_t>, which is... well not that optimal to say the least. :)

it'd be great that we at least add support for:

but as well would be great that we use not support float64_t features for DenseFeatures.

@vigsterkr vigsterkr changed the title Add Support for Combined and String features in trees Feb 15, 2017
@karlnapf
Copy link
Member

See #3313 for an example for such a patch

@djokester
Copy link

Can I take this up?

@karlnapf
Copy link
Member

Yeah do it !

@MikeLing
Copy link
Contributor

Hi @djokester , are you working on it right now? I would like to add this feature to kd-tree and cover-tree if it's ok due to I'm working on the KNN right now. However, I'm totally ok to forget this issue if you had already have some progress on it. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants