New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links in notebooks. #3702
Comments
Thanks for reporting. |
@karlnapf I would like to work on this. I'm planning to apply for real world applications project. This doesn't come under entrance for any other project right? |
The entrance tasks are not really project related, especially not those easy ones |
@karlnapf I think this can be closed now |
What about you run a linkchecker and then we close? :) |
I'm not sure I follow |
I meant: you could run an automated tool that verifies the links in all the notebooks in the repository. If broken ones are found, you send another patch, otherwise we close this issue. |
Sounds interesting. I'll get right to it. |
Here is a list of broken-links, that are not yet fixed https://gist.github.com/Red-devilz/67dee8c8afc2502202b16466ff6da225 |
Thanks for that! Really useful to have that list! |
Were all the links verified? |
@bhavukkalra the easiest is that you open the notebooks and try to open the links... of course there's a smarter way to do it. basically do a regex (for http://....) on the notebooks, get out the links and try to fetch them with curl or wget or any other command line tool, and if the status code is not 200 then it's a broken link |
and in fact if you write that shell script then could you please share it to this issue, coz then we can actually integrate that check into our CI ;) |
Sure. |
@bhavukkalra yes... but no need to generate a file. just parse the notebooks, get the links, test them and print the ones that are broken. and of course you can use python for this, whichever is the easiest for you |
I was successfully able to extract links from a ipython file. |
A few notebooks have web links that are not parsed correctly. Links missing http[s]://www. are opened as paths relative to the notebook server. Emails need 'mailto:' if they are intended to be a clickable link.
The following is a list of notebook files and 'bad' links.
doc/ipython-notebooks/clustering/GMM.ipynb
github.com/karlnapf
herrstrathmann.de
doc/ipython-notebooks/clustering/.ipynb_checkpoints/GMM-checkpoint.ipynb
github.com/karlnapf
herrstrathmann.de
ipython-notebooks/evaluation/xval_modelselection.ipynb
github.com/karlnapf
herrstrathmann.de
ipython-notebooks/statistical_testing/mmd_two_sample_testing.ipynb
github.com/karlnapf
herrstrathmann.de
soumyajitde.cse@gmail.com
github.com/lambday
The text was updated successfully, but these errors were encountered: