Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistical testing build error when USE_REF_COUNTING=OFF #3713

Closed
karlnapf opened this issue Mar 16, 2017 · 5 comments
Closed

statistical testing build error when USE_REF_COUNTING=OFF #3713

karlnapf opened this issue Mar 16, 2017 · 5 comments
Assignees
@lambday
Labels
good first issue Type: Bug
Milestone
Shogun 6.1.0

Comments

@karlnapf
Copy link
Member 

shogun/src/shogun/statistical_testing/internals/Block.cpp:51:16: error: ‘class shogun::CFeatures’ has no member named ‘ref_count’
  ASSERT(block->ref_count()==0);

Disabling ref counting results in a build error for the merged branch
@karlnapf karlnapf added this to the Shogun 6.0 milestone Mar 16, 2017
@karlnapf
Copy link
Member Author

Not sure if that was recently fixed, my build is a week old dev branch

@karlnapf
Copy link
Member Author

More care is needed!

@karlnapf
Copy link
Member Author

/nfs/nhome/live/ucabhst/git/shogun/shogun_develop/shogun/src/shogun/statistical_testing/internals/DataManager.cpp:388

@lambday
Copy link
Member

lambday commented Mar 16, 2017

@karlnapf we merged the fix yesterday :)

@karlnapf
Copy link
Member Author

ok so I need to rebase. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lambday lambday

Labels
good first issue Type: Bug
Projects
None yet
Milestone
Shogun 6.1.0
Development

No branches or pull requests
2 participants
@karlnapf @lambday