Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve object replication for classes with 3rd party dependencies #3725

Closed
lkuchenb opened this issue Mar 19, 2017 · 5 comments
Closed

Resolve object replication for classes with 3rd party dependencies #3725

lkuchenb opened this issue Mar 19, 2017 · 5 comments
Labels

Comments

@lkuchenb
Copy link
Contributor

There are several issues with shogun classes that depend on 3rd party libraries, e.g. CMKL or CLibSVM. The named two currently don't have any of their members registered as parameters and for the non-shogun ones (LibSVM, CLPLEX, GLPK, ...) it has to be checked upstream how to implement this first.

  • Check all shogun classes for Parameter registration. Test cases for clone() and equals() exist for CLibSVM etc, but are useless, since they always check out fine with no parameters!
  • Check 3rd party dependencies and how to replicate their objects.
@lkuchenb
Copy link
Contributor Author

The member variables in LibSVM classes could actually be moved to the train_machine scope, so maybe there is not much to do there.

@lkuchenb
Copy link
Contributor Author

I prepared a patch for MKL in #3730

@lkuchenb
Copy link
Contributor Author

And a patch for LibSVM classes in #3731

@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2020
@stale
Copy link

stale bot commented Mar 4, 2020

This issue is now being closed due to a lack of activity. Feel free to reopen it.

@stale stale bot closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant