Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuadraticTimeMMD.compute_variance_h0 fails on aarch64 #3870

Open
vigsterkr opened this issue Jun 26, 2017 · 4 comments
Open

QuadraticTimeMMD.compute_variance_h0 fails on aarch64 #3870

vigsterkr opened this issue Jun 26, 2017 · 4 comments

Comments

@vigsterkr
Copy link
Member

aarch64's float operations seems to be not so accurate :)
in QuadraticTimeMMD there's a 4.76837158203125e-07 error instead of 1E-10.
would it be a problem that we lower an error a bit:

[ RUN      ] QuadraticTimeMMD.compute_variance_h0
/home/buildslave/xenial_-_libshogun_-_aarch64/build/tests/unit/statistical_testing/QuadraticTimeMMD_unittest.cc:277: Failure
The difference between var and 0.0042963027954101562 is 4.76837158203125e-07, which exceeds 1E-10, where
var evaluates to 0.0042967796325683594,
0.0042963027954101562 evaluates to 0.0042963027954101562, and
1E-10 evaluates to 1e-10.
@lambday
Copy link
Member

lambday commented Jun 27, 2017

Hi @vigsterkr. I think it should be okay. These tests use a precomputed kernel matrix, which is of float32_t type. I think FLT_EPSILON should be okay in this case?

@karlnapf
Copy link
Member

@lambday want to fix? :) We need your help ...

@lambday
Copy link
Member

lambday commented Jun 28, 2017

@karlnapf sure! Will send a patch today.. :)

@vigsterkr
Copy link
Member Author

The difference between var and 0.0042963027954101562 is 4.76837158203125e-07, which exceeds 1.19209289550781250000000000000000000e-7F, where
var evaluates to 0.0042967796325683594,
0.0042963027954101562 evaluates to 0.0042963027954101562, and
1.19209289550781250000000000000000000e-7F evaluates to 1.1920928955078125e-07.``` :)

@vigsterkr vigsterkr reopened this Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants