Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASY: tag-register all raw arrays #4101

Closed
karlnapf opened this issue Jan 22, 2018 · 1 comment
Closed

EASY: tag-register all raw arrays #4101

karlnapf opened this issue Jan 22, 2018 · 1 comment

Comments

@karlnapf
Copy link
Member

See #4100

This is in order to fully transition to the new parameter framework.
Simple entrance task. We want to register all raw array parameters with the tags framework.

  1. Grep for add_vector in all of Shogun's code base
  2. For every parameter registration, add a watch_param as in the example PR tag-register raw array #4100
  3. Run tests (should be fine, but better check)
  4. Send PR
@ghost ghost mentioned this issue Jan 24, 2018
@karlnapf karlnapf changed the title tag-register all raw arrays EASY: tag-register all raw arrays Jan 24, 2018
@karlnapf
Copy link
Member Author

done via #4116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant