Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_format script fails to run #4118

Closed
ghost opened this issue Jan 24, 2018 · 1 comment
Closed

check_format script fails to run #4118

ghost opened this issue Jan 24, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 24, 2018

I faced an issue with check_format script.

It gives the following error:

Running clang-format-3.8 against branch develop, with hash 2e6dc14
git: 'clang-format-3.8' is not a git command. See 'git --help'.

I found a workaround by modifying script as follows:

- RESULT_OUTPUT="$(git clang-format-3.8 --commit $BASE_COMMIT --diff --binary which clang-format-3.8 $LIST)"
+ RESULT_OUTPUT="$(git clang-format --commit $BASE_COMMIT --diff --binary which clang-format-3.8 $LIST)"

After this, style check passes.
Has anyone faced this issue? How to fix this without modifying the script?

My system: arch-linux, installed clang from source.

@geektoni
Copy link
Contributor

This error is likely to be caused by not having installed the package clang-format-3.8 in your system as advised here. Clang alone is not enough to make check_format.sh work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants