Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixtures / templates in LibLinear unit test #4207

Closed
karlnapf opened this issue Mar 16, 2018 · 1 comment
Closed

Use fixtures / templates in LibLinear unit test #4207

karlnapf opened this issue Mar 16, 2018 · 1 comment

Comments

@karlnapf
Copy link
Member

karlnapf commented Mar 16, 2018

The unit tests for CLibLinear are highly redundant copy paste style code -- hard to maintain/read/change.
https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/classifier/svm/LibLinear_unittest.cc

This easy entrance task is to use googletest's fixture concept to reduce the number of lines of code in this test. It should be possible to reduce things down to 1-2 explicitly coded out tests.

Useful ressources

@vigsterkr
Copy link
Member

closing as this has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants