New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMM fails without LAPACK #4210
Comments
Have checked locally, |
@vinx13 great! thnx for checking this! so yeah then our unit test for GMM is not invariant for such case... which it should be as they are actually the same eigenvector |
in #4204 the integration tests fail (i.e. the mean of the mixture component), not the unit test. I am not sure whether the cluster centres might be permuted if the sign changes, or if the results are simply different. Did anyone check whether some unit tests fail as well? |
@karlnapf unit test? oh yeah mistyping... meant integration... and the whole solution is fsck-ed there... so that integration test with different EVs ends up having all different params... |
different EVs = opposite direction |
Ill dig into the GMM code and see whether we can make it invariant to the sign in GMM itself |
Maybe it would make sense to do some postprocessing after the backend call. |
---- i.e. dontlike |
fyi here's the generated output when LAPACK isn't available
|
Alternative is to do that in the GMM .... and all the other algorithms where such problems appear |
@karlnapf even more so ---- |
in this case ... good luck solving it :) |
in this case imo this shows how some of our integration tests are actually not the best. :) |
same story comes up with the randoms |
it seems not having LAPACK backend for eigen some of our tests are broken (see #4204), one of which is GMM.
The text was updated successfully, but these errors were encountered: