Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly exclude meta examples from build #4709

Open
karlnapf opened this issue Jul 5, 2019 · 1 comment
Open

Properly exclude meta examples from build #4709

karlnapf opened this issue Jul 5, 2019 · 1 comment

Comments

@karlnapf
Copy link
Member

karlnapf commented Jul 5, 2019

Certain meta examples are excluded from the build, if they have optional dependencies that are not met (e.g. GPL, NLOPT, etc). This is done here: https://github.com/shogun-toolbox/shogun/blob/develop/cmake/FindMetaExamples.cmake#L18

Currently, we do not even generate the code listings of excluded examples. This is bad since when generating documentation, sphinx will complain about missing code listings (an example page for the cookbook exists, but no example).

To avoid the need to have all dependencies installed, example listings should always be generated, but rather be excluded from the tests.

Good task for someone to learn about cmake, not too difficult but not trivial either

@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2020
@gf712 gf712 removed the stale label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants