Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test HMM #4917

Open
gf712 opened this issue Mar 12, 2020 · 2 comments
Open

Test HMM #4917

gf712 opened this issue Mar 12, 2020 · 2 comments
Labels
good first issue Tag: Testing

Comments

@gf712
Copy link
Member

gf712 commented Mar 12, 2020 •
edited

Currently there are only two python tests for HMM (distribution_mm.py and kernel_fisher.py) and there are no unit tests. Someone needs to write unit tests (and compare with some other library, preferably) and port the python examples to shogun's meta language!

Also would be good to remove and replace -DUSE_HMMPARALLEL and have a runtime option to run multiple threads (see how it is done in RandomForest for example), as any (good) C++17 compiler will support std::thread.
@vinnik-dmitry07
Copy link
Contributor

I am working on it.

@gf712
Copy link
Member Author

gf712 commented Mar 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Tag: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gf712 @vinnik-dmitry07