[WIP] Protobuf support in Shogun #1595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return int32_t | ||
| */ | ||
| int32_t get_posix_file_descriptor(); |
There was a problem hiding this comment.
this method is needed because of protobuf's streams works with posix file descriptors
There was a problem hiding this comment.
please send a patch for this separately - it might come handy
| @@ -0,0 +1,218 @@ | |||
| # Locate and configure the Google Protocol Buffers library. | |||
There was a problem hiding this comment.
FindProtobuf.cmake is already in cmake's modules. So just require the appropriate cmake version and drop this fail and the one above.
|
ok closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.