Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace setsX("name", obj_X) by sets("name", obj_X) #3409

Merged
merged 1 commit into from Aug 14, 2016

Conversation

sanuj
Copy link
Contributor

@sanuj sanuj commented Aug 5, 2016

@vigsterkr Here we go. 馃嵒

@lisitsyn
Copy link
Member

I am undecided yet due to one reason. What happens if we do obj.sets("kernel", GaussianKernel());? Is it CSGObject or CKernel? Won't there be some ambiguity?

@sanuj
Copy link
Contributor Author

sanuj commented Aug 11, 2016

@lisitsyn This works as expected:

import modshogun as sg
obj = sg.Obj()
gk = sg.GaussianKernel()
obj.sets("gaussian", gk)
obj.getsKernel("gaussian") == gk      # True

@lisitsyn lisitsyn merged commit 4e8c8eb into shogun-toolbox:feature/tags Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants