Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks for multi-constant concatenation? #23

Closed
momoadeli opened this issue May 16, 2016 · 1 comment
Closed

Breaks for multi-constant concatenation? #23

momoadeli opened this issue May 16, 2016 · 1 comment

Comments

@momoadeli
Copy link

momoadeli commented May 16, 2016

rev-collector fails when I use two constants to build an image path to 'testdefault.png'
(testdefault-XXXXXXX.png is NOT created):

`URLS = {
IMAGE_PREFIX:"",
IMAGE_BASE_LOCAL_CAST_BANNERS:"img/banners"}

DEFAULT_IMAGE = {
TEST:
{TESTDEFAULT:cf.URLS.IMAGE_PREFIX + URLS.IMAGE_BASE_LOCAL_CAST_BANNERS+ "/testdefault.png"
}
`
However, once I remove the second constant and define the path a little more explicitly, rev-collect works (testdefault-XXXXXXX.png is created):

DEFAULT_IMAGE = {
TEST:
{
TESTDEFAULT:cf.URLS.IMAGE_PREFIX + "img/banners/testdefault.png"
}
`
manifest is correct:
"img/banners/testdefault.png": "img/banners/testdefault-13626465c2.png"

Please advise.

Many Thanks!

@shonny-ua
Copy link
Owner

Hmmm... The rev-collector don't generate any manifest files. It's work for gulp-rev.

This module collect different generated manifests, and makes necessary replacements in html template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants