Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitout suffix file cannot work well #55

Closed
809662683 opened this issue Dec 20, 2018 · 4 comments
Closed

whitout suffix file cannot work well #55

809662683 opened this issue Dec 20, 2018 · 4 comments

Comments

@809662683
Copy link

809662683 commented Dec 20, 2018

my rev-manifest.json file content like
{ "js/act_create_task_add": "js/act_create_task_add-d5b3871a7a", "js/act_create_task_icon_list": "js/act_create_task_icon_list-0214817f5d", "js/act_create_task_list": "js/act_create_task_list-43930d8cf8", "js/act_history_list": "js/act_history_list-d7d8e12548", {

my html file content

<script src="../../../js/require.js" data-main="js/act_create_task_add"></script>

gulp.js
gulp.task('revFile',function(){ return gulp.src(['target/portalUI/*.json','src/**/page/**/*.html']) .pipe(revCollector({replaceReved: true,dirReplacements:{}})) .pipe(gulp.dest('target/portalUI')); })
after run this task , html file content not changed. why ?
thanks !

@shonny-ua
Copy link
Owner

"js/act_create_task_add": "js/act_create_task_add-d5b3871a7a",
does you not use the .js extension?

@809662683
Copy link
Author

809662683 commented Dec 21, 2018

yes, because i use requirejs framework ,
https://requirejs.org/
for example:
https://github.com/requirejs/example-multipage/blob/master/www/page1.html

<script data-main="js/page1" src="js/lib/require.js"></script>
image

@shonny-ua
Copy link
Owner

I wrote some test.
In this test , html file content is changed.
I detect wrong behavior using replaceReved: true in your without extensions case.
But without replaceReved param all works correctly.

@809662683
Copy link
Author

809662683 commented Dec 29, 2018

thanks a lot , I solved my problem, i found my project some file name like this:
"js/course_teacher_query.min": "js/course_teacher_query-d8208947a9"
this is make the plugin not work.... after delete it, problem is gone.
thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants