Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copy of VAL in the jenkins directory #6

Open
rpgoldman opened this issue Apr 4, 2019 · 5 comments
Open

Replace copy of VAL in the jenkins directory #6

rpgoldman opened this issue Apr 4, 2019 · 5 comments

Comments

@rpgoldman
Copy link
Contributor

Replace with another git submodule. Since VAL has bitrotted, it should probably be the patched version that @guicho271828 has.

This was referenced Apr 4, 2019
@rpgoldman
Copy link
Contributor Author

This isn't easy to do, since the state of VAL is still unsettled and its use in SHOP requires the addition of the -x command-line option. Needs further investigation, but the tests are fixed for now at least, as is use of validate in SHOP3 functions.

@guicho271828
Copy link
Contributor

Is it using any VAL-specific functionality? Otherwise you could consider https://github.com/guicho271828/ArriVAL for validation (only for ADL/PDDL though)

@guicho271828
Copy link
Contributor

oops I forgot that it was still missing action costs etc. (please forget about it for now)

@rpgoldman
Copy link
Contributor Author

I am using an extension to validate that adds a -x argument that will cause validate to exit with a non-zero status if the plan fails to validate.

I'm not sure how to get that patch incorporated in the upstream VAL: instead of modifying it slowly, they smashed a huge change in all at once, which makes my patch effectively un-rebase-able. Hence I have to use the old version.

(Editorial complaint: this kind of thing would be a lot easier if validate used getopt instead of a hand-written loop)

@rpgoldman
Copy link
Contributor Author

I would love to incorporate ArriVAL: VAL's parser is ... not nice. It may have started from a grammar, but by the time the authors were done turning that grammar into something that flex and bison could handle, it was an unreadable mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants