Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md release instructions outdated (low priority) #113

Closed
itsgarcia opened this issue Dec 18, 2018 · 1 comment
Closed

CONTRIBUTING.md release instructions outdated (low priority) #113

itsgarcia opened this issue Dec 18, 2018 · 1 comment

Comments

@itsgarcia
Copy link
Contributor

From speaking to Jean-Frederic Fortier and Doug Edey today it sounds like the rake instructions in Releasing may not be necessary/correct anymore:

  1. Tag the release commit on GitHub: bundle exec rake tag_release

Both indicated it should be fine to just merge version-bump PRs and deploy via shipit, so I just wanted to confirm that for documentation purposes.

@wvanbergen
@wvanbergen
Copy link
Contributor

Shipit can now tag releases itself - look at some of the other gems we have to see how to update the release setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wvanbergen @itsgarcia