Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloading checkout triggers an SMS with Shop Pay verification code #179

Closed
maxmamis opened this issue May 24, 2024 · 3 comments
Closed
Labels

Comments

@maxmamis
Copy link

maxmamis commented May 24, 2024

What area is the issue related to?

Checkout Sheet Kit

What version of Checkout Sheet Kit are you using?

3.0.0

Reproducible sample code

No response

Steps to Reproduce

In many cases when the preload method is called, the user is sent an OTP code for shop pay despite not yet opening the checkout view controller. This is disconcerting to the user, who is not expecting to get an SMS at this point and has nothing visible to use it for.

Steps to reproduce:

  1. With something in your cart, open the Shopify checkout sheet once and then close it. (This step might not be necessary, but for me it always triggers the bug. I'm not sure why.)
  2. Perform an action that causes the app to call ShopifyCheckoutSheetKit.preload again (e.g. adding something to the cart)

Expected Behavior

Nothing happens visibly, checkout sheet preloads in background

Actual Behavior

I receive a text message of the format "123456 is your Shop verification code"

Screenshots/Videos/Log output

RPReplay_Final1716570197.MOV

Storefront domain

yaysay.myshopify.com

@maxmamis maxmamis added the Bug label May 24, 2024
@DylanVann
Copy link

Also seeing this, the preload API is not usable given this issue

@kiftio
Copy link
Contributor

kiftio commented Jun 12, 2024

A fix has been deployed for this issue, but I haven't had chance to validate it yet. Let us know if you're still seeing the issue

@DylanVann
Copy link

DylanVann commented Jun 21, 2024

@kiftio I'm still seeing this issue

I am using https://github.com/Shopify/checkout-sheet-kit-react-native but I've checked the Pod is on version 3.0.1

I can see the Sec-Purpose header is set on the request:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants