Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Dark Mode View Controller #66

Closed
tsopin opened this issue Nov 25, 2023 · 3 comments
Closed

Bug Report: Dark Mode View Controller #66

tsopin opened this issue Nov 25, 2023 · 3 comments

Comments

@tsopin
Copy link

tsopin commented Nov 25, 2023

The color scheme of the modal ViewController is based on system settings, instead of the theme passed to ShopifyCheckoutKit.configuration.colorScheme.
The light checkout can be presented in a dark ViewController.

IMG_0016

@markmur
Copy link
Contributor

markmur commented Dec 12, 2023

@tsopin apologies for the delayed response here.

Do you want the header to be light? or do you want the checkout to be dark?

Have you tried using the automatic ColorScheme option in your configuration?

@tsopin
Copy link
Author

tsopin commented Dec 12, 2023

Thank you for the reply!

I need the header to align with the value set in the configuration.

In this instance, while iOS was set to dark mode, my app was set to light mode, which was passed to the ShopifyCheckoutKit.configuration.colorScheme.

The checkout content adhered to the .light setting, but the view controller and its header conformed to the system's dark mode setting.

No, I haven't used automatic since my app overrides the system's settings.

@markmur
Copy link
Contributor

markmur commented Dec 13, 2023

The backgroundColor configuration option should help with this. It will set the background color of the webview - which will also apply to the header. So if you set it to white for example, the whole sheet will be white when loading, and the header should remain white when finished loading.

Let me know if this works for you. Note that you may also need to modify the system text color to correct the text color of "checkout" in the header.

@tsopin tsopin closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants