Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add missing CustomerSegmentSelector component #68

Open
wisniewski94 opened this issue Apr 19, 2023 · 2 comments
Open

[FEATURE] Add missing CustomerSegmentSelector component #68

wisniewski94 opened this issue Apr 19, 2023 · 2 comments

Comments

@wisniewski94
Copy link
Contributor

wisniewski94 commented Apr 19, 2023

Feature request summary

AppBridge resource picker does not have "CustomerSegment" resource type so I believe this issue should be resolved in @shopify/app-bridge-react first.

image

Rationale

This component is listed in the docs but cannot be found anywhere in the GitHub:

<CustomerEligibilityCard
  eligibility={eligibilityField}
  selectedCustomerSegments={selectedCustomerSegmentsField}
  selectedCustomers={selectedCustomersField}
  customerSegmentSelector={
    <CustomerSegmentSelector
      selectedCustomerSegments={selectedCustomerSegmentsField}
    />
  }
  customerSelector={
    <CustomerSegmentSelector selectedCustomers={selectedCustomersField} />
  }
/>

https://github.com/Shopify/discount-app-components/tree/main/src/components/CustomerEligibilityCard

@wisniewski94
Copy link
Contributor Author

Okay, my bad - I have found a link to the tutorial: https://shopify.dev/docs/api/discounts/components/customer-eligibility-card

Yet it deserves to be at least added to the documentation

@maneko00
Copy link

The tutorial is written to be implemented in a node template.
Are there any plans to support remix templates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants