Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discount is not active message is showing with DiscountStatus.Active #85

Closed
Waynenabors opened this issue Aug 4, 2023 · 0 comments · Fixed by #86
Closed

Discount is not active message is showing with DiscountStatus.Active #85

Waynenabors opened this issue Aug 4, 2023 · 0 comments · Fixed by #86
Assignees
@mathiusj

Comments

@Waynenabors
Copy link

This is confusing because when you view and active discount you get a message under the performance section that says the discount is not active.

I think isEditing is supposed to be !isEditing on this line.

discount-app-components/src/components/SummaryCard/components/Performance/Performance.tsx

Line 65 in 5e51eee

{(isEditing || status === DiscountStatus.Scheduled) && (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathiusj mathiusj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove isEditing from not active status Shopify/discount-app-components
2 participants
@Waynenabors @mathiusj