You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the "hack" of f.inlineVerifier on Ferry and make it more integrated into Ferry directly.
Possibly review the Verifier interface to see if it needs to be extended or removed.
Write some sort of test for race condition within InlineVerifier.verifyallEventsInStore(). Specifically, if a row is added to the BinlogVerifyStore between the .Batches() call and .RemoveVerifiedBatches() call, that row must remain present after .RemoveVerifiedBatches().
This is somewhat non-trivial as there's no easy way to mock methods and the race condition is entirely contained within verifyAllEventsInStore, a private method.
A possible way to test this kind of is to add the same row multiple times and see if the counter has increased proportionally. Then, run verifyAllEventsInStore once and see if the counter only decreases by 1 time, or something along this line of thought.
InlineVerifier is likely broken with the ControlServer and thus copydb.
ColumnCompressionConfig is only used by the InlineVerifier. Should either move it into the InlineVerifierConfig or make the InlineVerifierConfig and thus InlineVerifier a first class member of Ghostferry
The text was updated successfully, but these errors were encountered:
f.inlineVerifier
onFerry
and make it more integrated into Ferry directly.Verifier
interface to see if it needs to be extended or removed.InlineVerifier.verifyallEventsInStore()
. Specifically, if a row is added to theBinlogVerifyStore
between the.Batches()
call and.RemoveVerifiedBatches()
call, that row must remain present after.RemoveVerifiedBatches()
.verifyAllEventsInStore
, a private method.verifyAllEventsInStore
once and see if the counter only decreases by 1 time, or something along this line of thought.The text was updated successfully, but these errors were encountered: