Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release master? #62

Closed
rmosolgo opened this issue Aug 10, 2017 · 2 comments
Closed

Release master? #62

rmosolgo opened this issue Aug 10, 2017 · 2 comments

Comments

@rmosolgo
Copy link
Contributor

Hi, would you mind releasing master to rubygems? 0.3.3 has the caching patch which was removed on master. Master is testing a bit better for but it's easier for our CI to point at rubygems. Could you cut a new version?
@dylanahsmith
Copy link
Contributor

Pushed a 0.3.4 version release with the bug fixes. As you noted, there is a revert in there that could cause a performance regression from not caching loaders after they are resolved, but that was needed to fix a correctness bug to avoid batching across mutation fields.

@rmosolgo
Copy link
Contributor Author

Thanks, it's working great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanahsmith @rmosolgo