Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Vite version of React Server Components with Hydrogen #42

Closed
jplhomer opened this issue Jul 29, 2021 · 0 comments
Closed

Test Vite version of React Server Components with Hydrogen #42

jplhomer opened this issue Jul 29, 2021 · 0 comments

Comments

@jplhomer
Copy link
Contributor

Blocked by Shopify/hydrogen#40
Part of Shopify/hydrogen#35

Once we have react-server-dom-vite in the React repo, we should swap out our reverse-engineered implementation with the real version.

There are two caveats with this:

  • SSR won't work (yet)
  • There might be critical bugs

I'm particularly interested in the latter part, because we'll need to fix these bugs and blockers before RSC goes live. This is an opportunity to contribute fixes upstream in React and to the third-party packages we use.

For example: we might notice that React Router stops working. Or the way we're using Context in Hydrogen doesn't work in RSC.

@jplhomer jplhomer transferred this issue from another repository Nov 5, 2021
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this issue Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant