Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Packages To Have Custom Public Paths #36

Closed
apeacock1991 opened this issue Oct 13, 2020 · 1 comment
Closed

Allow Packages To Have Custom Public Paths #36

apeacock1991 opened this issue Oct 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@apeacock1991
Copy link
Contributor

apeacock1991 commented Oct 13, 2020

Description

Currently the public folder is hard-coded as app/public, which may not work for all users of the gem. They may wish to define their own public folder, and if none is defined, default to app/public.

Why?

Depending on the architecture of the application, app/public might just not make sense, or at least not be cohesive with the rest of the folder structure. Consider a layered architecture for example, where you break up the layers of your application via technical partition (i.e. presentation layer, domain layer, infrastructure layer etc.). Your top-level folders in your package would typically be /presentation, /domain etc., so logically in that architecture you would want to select the layer that makes sense to expose the package from, and app/public conflicts with that vision.

I've raised a PR here that I believe introduces that feature, and seems to work nicely.

@apeacock1991 apeacock1991 added the bug Something isn't working label Oct 13, 2020
@apeacock1991 apeacock1991 changed the title [Bug Report] Allow Packages To Have Custom Public Paths Oct 13, 2020
@wildmaples
Copy link
Contributor

This feature request as been merged in #37

@wildmaples wildmaples added enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2021
shioyama pushed a commit that referenced this issue May 21, 2021
Test packwerk on Ruby 2.7 along with 2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants