Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cacheable's railtie references a middleware class from Shopify #16

Closed
codyfauser opened this issue Feb 14, 2014 · 5 comments
Closed

Cacheable's railtie references a middleware class from Shopify #16

codyfauser opened this issue Feb 14, 2014 · 5 comments

Comments

@codyfauser
Copy link

https://github.com/Shopify/cacheable/blob/master/lib/cacheable/railtie.rb#L5

@cjoudrey
Copy link

@codyfauser @arthurnn would it make sense to remove the railtie.rb and add this to the README.md:

config.middleware.insert_before 'Rack::ETag', 'Cacheable::Middleware'

@arthurnn
Copy link

yep... I think we should remove that line from the reailtie, and add the instruction into the readme..

I can do that, if you didnt start it yet.

@cjoudrey
Copy link

@arthurnn I didn't start. I was asking because I was going to get a README up. :)

@arthurnn
Copy link

:shipit:

@cjoudrey
Copy link

cjoudrey commented Dec 2, 2016

Fixed by #22

@cjoudrey cjoudrey closed this as completed Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants