Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy name conflicts leak ports #68

Closed
xthexder opened this issue Jul 20, 2015 · 0 comments
Closed

Proxy name conflicts leak ports #68

xthexder opened this issue Jul 20, 2015 · 0 comments

Comments

@xthexder
Copy link
Contributor

If a proxy is added with a conflicting name, but not a conflicting port, the port will be opened before an error is returned, leaving the port open.
There's currently no way to close the port other than restarting toxiproxy.

See tests added in the toxiproxy2 branch: 53773f6#diff-095e965c1e92c9277036371d89bd083cR262
and the tests failing here: https://circleci.com/gh/Shopify/toxiproxy/295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xthexder