Stop using getContext() methods for SalesChannelContext instances

[moorl]

Description
In this example I have two similar events with different methods to get the SalesChannelContext. Its a problem and force us devs to duplicate similar code. Maybe the first step could be to add a equal method with the right name to get the SalesChannelContext.

Example

    public static function getSubscribedEvents(): array
    {
        return [
            ProductListingCollectFilterEvent::class => 'addFilter',
            ProductListingCriteriaEvent::class => 'addCriteria',
            ProductPageCriteriaEvent::class => 'addCriteria'
        ];
    }

    public function addCriteria($event)
    {
        if ($event instanceof ProductListingCriteriaEvent) {
            $salesChannelContext = $event->getSalesChannelContext();
        } elseif ($event instanceof ProductPageCriteriaEvent) {
            $salesChannelContext = $event->getContext();
        }

        $criteria = $event->getCriteria();
        //$criteria->addAssociation('merchantStocks.merchant');
        //$criteria->addAggregation(new EntityAggregation('merchants', 'product.merchantStocks.merchant.id', MerchantDefinition::ENTITY_NAME));

        $criteria->addAssociation('merchants');
        $criteria->addAggregation($this->getEntityAggregation());
        $criteria->addFilter(new MultiFilter(MultiFilter::CONNECTION_OR, [
            new EqualsFilter('merchants.salesChannelId', $salesChannelContext->getSalesChannel()->getId()),
            new EqualsFilter('merchants.salesChannelId', null)
        ]));
    }

[shopwareBot]

Hello,

thank you for creating this issue.
I have opened a ticket on our Issue Tracker for you. See the ticket link: https://issues.shopware.com/issues/NEXT-11926

Please use this ticket to track the state of your issue.

[mitelg]

oh, that should not be the case. I will take care of that

[mitelg]

hey @moorl

thanks again for bringing this up. yesterday we merged a new convention (ADR) on how events have to look like in the future: dacf9cf

the event you mentioned in the first place, will only be fixed with the upcoming major version 6.4.0.0 because changing the return type would be a breaking change. But from now on, there is already a getSalesChannelContext present, which will be usable from the next minor version 6.3.4.0