Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not defined env APP_URL on new setups #1855

Closed
wants to merge 0 commits into from

Conversation

mynameisbogdan
Copy link
Contributor

@mynameisbogdan mynameisbogdan commented May 11, 2021

1. Why is this change necessary?

To prevent the error Environment variable not found: "APP_URL". on new setups.

2. What does this change do, exactly?

Sets a default value of http://localhost for APP_URL

3. Describe each step to reproduce the issue or behaviour.

Run bin/console system:setup

4. Please link to the relevant issues (if any).

shopware/production#101

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented May 11, 2021

CLA assistant check
All committers have signed the CLA.

@J-Rahe J-Rahe self-assigned this May 11, 2021
@J-Rahe
Copy link
Contributor

J-Rahe commented May 11, 2021

Hey @mynameisbogdan, could you please sign the cla?

@mynameisbogdan
Copy link
Contributor Author

hello @J-Rahe, ok, just did.

Thank you.

@@ -5,6 +5,7 @@
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">

<parameters>
<parameter key="env(APP_URL)">http://localhost</parameter>
Copy link
Collaborator

@pweyck pweyck May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recently added a default of ''. Could you change it here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pweyck the bug it's fixed with that empty string as well. I created a new PR #1859 regarding just the change of the default value to http://localhost.

@mynameisbogdan
Copy link
Contributor Author

I created a new PR #1859 regarding just the change of the default value to http://localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants