-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not defined env APP_URL on new setups #1855
Conversation
Hey @mynameisbogdan, could you please sign the cla? |
hello @J-Rahe, ok, just did. Thank you. |
@@ -5,6 +5,7 @@ | |||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
|
|||
<parameters> | |||
<parameter key="env(APP_URL)">http://localhost</parameter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recently added a default of ''
. Could you change it here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6c56c33
to
fae1819
Compare
fae1819
to
5e55723
Compare
I created a new PR #1859 regarding just the change of the default value to |
1. Why is this change necessary?
To prevent the error
Environment variable not found: "APP_URL".
on new setups.2. What does this change do, exactly?
Sets a default value of
http://localhost
forAPP_URL
3. Describe each step to reproduce the issue or behaviour.
Run
bin/console system:setup
4. Please link to the relevant issues (if any).
shopware/production#101
5. Checklist