Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion error messages not localized #2902

Open
AltayAkkus opened this issue Dec 27, 2022 · 0 comments
Open

Promotion error messages not localized #2902

AltayAkkus opened this issue Dec 27, 2022 · 0 comments
Labels

Comments

@AltayAkkus
Copy link
Contributor

PHP Version

trunk

Shopware Version

trunk

Expected behaviour

Error messages (like "End date needs to be after the start date") should be localized to the users language

Actual behaviour

Only the english messages are shown

How to reproduce

  1. Create a random promotion and cause a error (place the end date before the start date)
  2. See that the text is english

This because here
https://github.com/shopware/platform/blob/e91d42f995e192aac6f2504a950ad55fb9b13ccc/src/Core/Checkout/Promotion/Validator/PromotionValidator.php#L245-L251
and all the other buildViolation calls a snippet key is defined, but the snippet is not, so the default english fallback is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant