Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Validation Violation Localization #2903

Closed

Conversation

AltayAkkus
Copy link
Contributor

@AltayAkkus AltayAkkus commented Dec 27, 2022

1. Why is this change necessary?

To fix #2902

2. What does this change do, exactly?

Add the correct snippets, and improve consistent dotting in the fallback messages.

3. Describe each step to reproduce the issue or behaviour.

Create a random promotion and cause a error (place the end date before the start date)
See that the text is english

4. Please link to the relevant issues (if any).

#2902

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@AltayAkkus AltayAkkus changed the title FixValidationLocalization Fix Validation Violation Localization Dec 27, 2022
@shyim
Copy link
Member

shyim commented Jan 12, 2023

@AltayAkkus how is the progress here?

@shyim
Copy link
Member

shyim commented Jun 30, 2023

Hey,

I will close this PR as it's inactive for a while. Feel free to create a new one when you applied the requested changes

@shyim shyim closed this Jun 30, 2023
@shyim shyim added the Declined label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promotion error messages not localized
2 participants