-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-14691 - Add pseudo modal twig blocks #3567
NEXT-14691 - Add pseudo modal twig blocks #3567
Conversation
|
data-bs-dismiss="modal" | ||
aria-label="Close"> | ||
{# @deprecated tag:v6.7.0 - Block will be removed. Use `component_pseudo_modal_close_btn_content` instead. #} | ||
{% block product_detail_zoom_modal_close_button_content %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new block component_pseudo_modal_close_btn_content
is missing :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, it's added now 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good :-)
577e246
to
3f9f13e
Compare
Hi @lacknere, thank you for your contribution 🎉 and sorry for my late review. I know these are "just" blocks, but do you really need blocks on every single element? The good thing about the pseudo-modal right now is, that the general modal markup could change in the background (for example due to a Bootstrap update) and it would not be an issue because |
3f9f13e
to
bb48ee4
Compare
@tobiasberge I've removed the modal dialog and content blocks. The new blocks are now "overall", "header", "title", "close button", "body" and "back button". Is that okay? |
Hi @lacknere thank you. 👍 LGTM. And good catch with the wrong block naming |
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
1. Why is this change necessary?
Pseudo modal template is missing many twig blocks which may be used to override/extend the template easily from themes/plugins.
2. What does this change do, exactly?
Add the missing twig blocks and deprecate an inappropriately named block.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
NEXT-14691
5. Checklist