New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin zip import command #558

Closed

JoshuaBehrens wants to merge 6 commits into shopware:master from JoshuaBehrens:feature/plugin-zip-import-command

Contributor

JoshuaBehrens commented Feb 20, 2020 •

edited

1. Why is this change necessary?

There is still no really good way to version community store plugins.

sw:store:download is not available in shopware 6 yet
packages.friendsofshopware.com is not officially supported

Now you can at least version a downloaded plugin file and simply do:
bin/console plugin:zip-import SwagBundle.zip && bin/console plugin:install --activate SwagBundle

2. What does this change do, exactly?

Add a new command to import plugin zip files. Add optional parameter to disable file deletion on import via CLI.

3. Describe each step to reproduce the issue or behaviour.

Have a previously downloaded plugin zip file
Open /admin
Open plugin management
Upload zip file
Install plugin
Activate plugin
Be annoyed that it is not possible via CLI in an easy way to do the same

4. Checklist

I have written tests and verified that they fail without my change
I have squashed any insignificant commits
I have written or adjusted the documentation according to my changes
This change has comments for package types, values, functions, and non-obvious lines of code
I have read the contribution requirements and fulfil them.

shopwareBot assigned pantrtxp

Contributor

pantrtxp commented Feb 21, 2020

Hi @JoshuaBehrens

Thanks again for your contribution.
Please add tests, documentation and watch for deprecations before we proceed with importing your PR

Sunny regards
Pantrtxp

pantrtxp added the Incomplete label

Contributor Author

JoshuaBehrens commented Feb 21, 2020

Wait? What deprecations? Am I already using these? Isn't this a task for a reviewer that there is such a conflict?

Where are any commands documented that I have to do as well?

Ok I will look for a way to test this.

Contributor Author

JoshuaBehrens commented Feb 22, 2020

I added docs and tests. I did not test the command itself as there are no templates how to do that yet but I test my changed behaviour.

shopwareBot commented Feb 27, 2020

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-7340

Please use this issue to track the state of your pull request.

shopwareBot added the Scheduled label

pantrtxp removed the Incomplete label

pantrtxp suggested changes

View reviewed changes

Contributor

pantrtxp left a comment

Hi @JoshuaBehrens
could you please have a look at these requests?

src/Core/Framework/DependencyInjection/plugin.xml Outdated Show resolved Hide resolved

src/Core/Framework/Plugin/Command/PluginZipImportCommand.php Outdated Show resolved Hide resolved

pantrtxp suggested changes

View reviewed changes

Contributor

pantrtxp left a comment

Hi @JoshuaBehrens
could you please have a look at these requests?

pantrtxp suggested changes

View reviewed changes

Contributor

pantrtxp left a comment

Hi @JoshuaBehrens
could you please have a look at these requests?

pantrtxp suggested changes

View reviewed changes

Contributor

pantrtxp left a comment

Hi @JoshuaBehrens
could you please have a look at these requests?

pantrtxp suggested changes

View reviewed changes

Contributor

pantrtxp left a comment

Hi @JoshuaBehrens
could you please have a look at these requests?

Contributor

pantrtxp commented Feb 27, 2020

Sorry for this comment fuck up but github had some issues posting my comment

Contributor Author

JoshuaBehrens commented Feb 27, 2020

It is ok :) and if you did it on purpose it is ok for me as well. I also post some nonsense here as well 😅

pantrtxp added Incomplete and removed Scheduled labels

Contributor

pantrtxp commented Mar 9, 2020

@JoshuaBehrens would you accept these changes?
this is the last step to getting this merged :)

Contributor Author

JoshuaBehrens commented Mar 9, 2020

I'll get on it ASAP 🚀

Contributor

pantrtxp commented Mar 19, 2020

@JoshuaBehrens push again 🙈

Contributor Author

JoshuaBehrens commented Mar 19, 2020

Yes I am aware of this being open. Gimme time for the weekend. That looks good for it.

pantrtxp added Scheduled and removed Incomplete labels

Contributor

pantrtxp commented Mar 23, 2020

Sadly here are some failures as well.
Could you run the phpunit tests locally (after rebasing) and check out the failing ones?
Tests: 44, Assertions: 365, Failures: 18.

We are currently fixing the travis CI so you can rely on this again
Sorry for the inconvenience :(

pantrtxp added Incomplete Scheduled and removed Scheduled Incomplete labels

JoshuaBehrens force-pushed the feature/plugin-zip-import-command branch from 94d855f to 046efd6 Compare

March 27, 2020 06:58

Contributor Author

JoshuaBehrens commented Mar 27, 2020

After a rebase lots of tests fail as a refresh_token table is missing although I ran all the migrations :/

pantrtxp added the Incomplete label

Contributor

pantrtxp commented May 5, 2020

Hi @JoshuaBehrens
This PR is still incomplete.
Will you please update this PR?

Sunny regards
Pantrtxp

Contributor Author

JoshuaBehrens commented May 5, 2020

I can retry testing it but the last time I tried my tests were not working because of a missing google client dependency.

I will also change my doc updates for the new layout.

tobiasberge assigned ssltg

Contributor

ssltg commented May 27, 2020

Hi @JoshuaBehrens,
can you take a look again, your test suite works again I've heard through the grapevine ;-)

Contributor Author

JoshuaBehrens commented May 27, 2020 •

edited

Spooky

But yes, I'll do

Member

mitelg commented May 28, 2020

*once your branch is rebased 😉

JoshuaBehrens added 6 commits

June 5, 2020 13:26


          Make zip file deletion on import optional

cee7fc6


          Add command to import zip files

90ca90a


          Add zip handling test for keeping the zip file

3d04d7a


          Add docs for plugin imports

019aeac


          Make deleting the zip file afterwards optional

b79d660


          Change services.xml to match conventions

1a375fd

JoshuaBehrens force-pushed the feature/plugin-zip-import-command branch from 046efd6 to 1a375fd Compare

June 5, 2020 11:28

Contributor Author

JoshuaBehrens commented Jun 5, 2020

Hey @mitelg rebase is out. I hope I included all expectations we had during this conversation

Contributor Author

JoshuaBehrens commented Jun 15, 2020

Tests look good :)

shopwareBot commented Jun 16, 2020

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9223

Please use this issue to track the state of your pull request.

shopwareBot added the Scheduled label

ssltg removed the Incomplete label

shopwareBot pushed a commit that referenced this pull request


          Change services.xml to match conventions

16d7e67

fixes #558

shopwareBot closed this in


      shopware/core@f7438fd

Member

mitelg commented Jun 17, 2020

thanks for your contribution @JoshuaBehrens 👍 🎉 💙

mitelg added Accepted and removed Scheduled labels

Member

mitelg commented Jun 17, 2020

merged with d464970

Contributor Author

JoshuaBehrens commented Jun 17, 2020

Thanks :) You're welcome

JoshuaBehrens deleted the feature/plugin-zip-import-command branch

June 17, 2020 11:46

This was referenced Jun 23, 2023

[Snyk] Fix for 1 vulnerabilities sgmelayu/platform#543

Open

[Snyk] Fix for 1 vulnerabilities sgmelayu/platform#544

Open

mitelg added the Accepted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment