Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Brand type to brand schema #2291

Closed
wants to merge 1 commit into from

Conversation

tinect
Copy link
Contributor

@tinect tinect commented Jan 31, 2022

1. Why is this change necessary?

google reports Ungültiger Objekttyp für Feld "brand"

2. What does this change do, exactly?

adjust type for brand

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@JoshuaBehrens
Copy link
Contributor

@tinect https://github.com/tinect/TinectBrandSeoFix you can brag a bit about having a ready solution as a plugin :D

@tinect
Copy link
Contributor Author

tinect commented Jan 31, 2022

@tinect https://github.com/tinect/TinectBrandSeoFix you can brag a bit about having a ready solution as a plugin :D

Thank you.... stalker 😆

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-19898

Please use this issue to track the state of your pull request.

@leichteckig
Copy link
Contributor

Thank you @tinect for your contribution! 💙

@tinect tinect deleted the fixedBrandSchema branch February 3, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants