Missing data on API

[Schrank]

PHP Version

PHP 7.4.26 (cli) (built: Nov 22 2021 09:47:55) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.26, Copyright (c), by Zend Technologies with Xdebug v3.0.3, Copyright (c) 2002-2021, by Derick Rethans

Shopware Version

v6.4.7.0 Stable Version

Expected behaviour

When I add an association to a product like this:

criteria.getAssociation('seoUrls').addAssociation('salesChannel.domains')

Then I expect the response from the API to include all domains on the salesChannel.

Actual behaviour

The domain is missing.

How to reproduce

const {Criteria} = Shopware.Data;

Shopware.Component.override('sw-product-detail',
    {
        computed: {
            productCriteria() {
                const criteria = this.$super('productCriteria');
//                criteria.addAssociation('visibilities.salesChannel.domains'); // FIX
                criteria.getAssociation('seoUrls')
                    .addAssociation('salesChannel.domains')
                    .addAssociation('language');

                return criteria;
            }
        }
    }
);

And then have a look into the network tab.

Problem

The problems originates most likely here:

\Shopware\Core\Framework\Api\Serializer\JsonApiEncoder::serializeEntity

If I remove the first lines, then the missing domain is there.

protected function serializeEntity(ResponseFields $fields, Entity $entity, EntityDefinition $definition, JsonApiEncodingResult $result, bool $isRelationship = false): void
{
//        if ($result->containsInData($entity->getUniqueIdentifier(), $definition->getEntityName())
//            || ($isRelationship && $result->containsInIncluded($entity->getUniqueIdentifier(), $definition->getEntityName()))
//        ) {
//            return;
//        }

So I guess you try to avoid serializing an entity twice, but if the first entity doesn't contain the data, then the data is missing down another branch the entity-tree.

E.g. product -> visibilities -> salesChannel does not contain domains
product -> seoUrls -> salesChannel -> domains contain the domains

But because the first salesChannel was already added, the second is skipped.

Workaround

As expected, with criteria.addAssociation('visibilities.salesChannel.domains'); as a workaround the domains are added in the beginning and therefore not a wrong caching instance is used.