Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix CustomerImporter.php #22

Closed
wants to merge 2 commits into from
Closed

Bugfix CustomerImporter.php #22

wants to merge 2 commits into from

Conversation

micronax
Copy link

@micronax micronax commented Oct 4, 2017

No description provided.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-8455.

Please use this issue to track the state of your pull request.

DennisGarding
DennisGarding requested changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@DennisGarding DennisGarding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, we need some information about the error. What is the error?

Obviously only a different spelling is chosen here

Components/DbServices/Import/CustomerImporter.php
VALUES (1, {$customer['newslettergroupID']}, {$customer['email']});";
$this->db->query($sql);
$sql = 'INSERT INTO s_campaigns_mailaddresses (customer, groupID, email)
VALUES (1, ' . $customer['newslettergroupID'] . ',"' . $customer['email'] . '");';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL query is nowhere executed

@micronax
Copy link
Author

micronax commented Oct 5, 2017

Shoot! I forgot to paste the $this->db->query($sql); statement. I added it in a separate commit.

The bug I fixed is documented in the official shopware forum:

https://forum.shopware.com/discussion/41654/migration-von-prestashop-probleme-beim-kundenimport-sql-syntax-near-gmx-de

@micronax
Copy link
Author

Siehe auch: https://issues.shopware.com/issues/PT-7540

@astehlik astehlik mentioned this pull request Apr 15, 2018
Closed
@mitelg
Copy link
Contributor

mitelg commented Nov 22, 2018

hey @micronax
unfortunately the current state of your PR has a conflict. is it still relevant? if so, could you please rebase your PR to the current master?
sorry for the late response! 🙏

@mitelg
Copy link
Contributor

mitelg commented Feb 16, 2022

hey @micronax

Sorry for the late answer!
The corresponding ticket was closed. If this change is still relevant for you, please feel free to create a new PR.

@mitelg mitelg closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisGarding DennisGarding DennisGarding requested changes

Assignees
No one assigned
Labels
Declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@micronax @shopwareBot @mitelg @DennisGarding