Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when used with alpha-nvim #314

Closed
vincentlabelle opened this issue Mar 15, 2024 · 5 comments · Fixed by #317
Closed

Issue when used with alpha-nvim #314

vincentlabelle opened this issue Mar 15, 2024 · 5 comments · Fixed by #317
Labels
need investigation When an issue lack context/is not straight forward to solve not confirmed when a bug is reported but not yet reproduced

Comments

@vincentlabelle
Copy link

Description

When NNP is triggered via enableOnVimEnter and I open neovim on my dashboard styled greeter made with alpha-nvim, the whole dashboard is slightly off center. Then, if I proceed to a file from the dashboard, everything is centered properly except the autocomplete menu. Strangely, if prior to proceeding to a file, I move the cursor (on the dashboard) it brings everything back to the center (and I don't have any issues when proceeding to a file).

If I open vim on a file or folder, there is no issue.

Thanks for the amazing plugin! 👍

Steps to reproduce

I am only able to reproduce on a wide screen (i.e., 34"), and I don't have the issue otherwise.

  1. Set enableOnVimEnter to true
  2. Setup a dashboard greeter with alpha-nvim
  3. Open the dashboard

Expected behavior

Everything is centered properly when opening the greeter, or the NNP trigger is disabled until the next buffer. It might be possible to solve this using a similar approach to #17?

Environment

  • Neovim version: 0.9.5
  • no-neck-pain.nvim version: 1.8.1
  • Plugin clash: alpha-nvim
@shortcuts shortcuts added need investigation When an issue lack context/is not straight forward to solve not confirmed when a bug is reported but not yet reproduced labels Mar 15, 2024
@shortcuts
Copy link
Owner

Hey @vincentlabelle, thanks for reporting the issue and I'm glad you like the plugin!!

I've tried reproducing it but so far no luck (I'm on no-neck-pain latest version, 1.8.3), I've joined a recording so you can let me know if you have a different config/do different input

issue314.mov

@vincentlabelle
Copy link
Author

vincentlabelle commented Mar 16, 2024

Hey @shortcuts, thanks for looking into the issue!

I don't see anything from the video in terms of config/input that could be the cause of the discrepancy. I use the dashboard theme of alpha rather than the startify theme, but I doubt that's relevant.

I've tried updating to version 1.8.3, but I still have the issue.

I've taken two videos to show how I get the issue on a 34" screen with an aspect ratio of 21:9, but I don't get the issue on a 32" screen with an aspect ratio of 16:9. I hope this can help troubleshoot.

34-inch-21-9-aspect-ratio.mp4
32-inch-16-9-aspect-ratio.mp4

@shortcuts
Copy link
Owner

shortcuts commented Mar 16, 2024

Thanks a lot @vincentlabelle for the throughout reproduction, I don't have such screen at home so can't really try it myself but looking at the recording my guess is that #317 will fix it. Do you have a way to try the fix by installing this specific branch? e.g. if you use lazy.nvim you can do:

return {
    "shortcuts/no-neck-pain.nvim",
    branch = "feat/support-alpha",
    ....
}

@vincentlabelle
Copy link
Author

Thanks @shortcuts for being so responsive! I tested #317, and it fixes the issue. 😄

@shortcuts
Copy link
Owner

Thanks @shortcuts for being so responsive! I tested #317, and it fixes the issue. 😄

Nice to hear!! Thanks for testing and using the plugin :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need investigation When an issue lack context/is not straight forward to solve not confirmed when a bug is reported but not yet reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants