Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scratchPad): provide pathToFile option #332

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

shortcuts
Copy link
Owner

馃搩 Summary

It's hard to compose a scratchpad file location today, it requires 3 props to determine the full pathToFile and the custom filetype doesn't work everytime.

The idea is to propose a single property that does it all, which will deprecate all the other options in the next major

before, in order to define custom buffers

buffers = {
    left = {
        bo = {
            filetype = "custom"
        },
        scratchPad = {
            enabled = true,
            fileName = "notes",
            location = "~/Documents"
        },
    },
    right = {
        bo = {
            filetype = "md"
        },
        scratchPad = {
            enabled = true,
            fileName = "foo",
            location = "./bar/baz"
        },
    },
},

now

buffers = {
    left = {
        bo = {
            filetype = "custom"
        },
        scratchPad = {
            enabled = true,
            pathToFile = "~/Documents/notes.custom"
        },
    },
    right = {
        scratchPad = {
            enabled = true,
            pathToFile = "./bar/baz/foo.md"
        },
    },
},

@shortcuts shortcuts self-assigned this Mar 27, 2024
@shortcuts shortcuts merged commit 9a8d96d into main Mar 27, 2024
7 checks passed
@shortcuts shortcuts deleted the feat/pathToFile branch March 27, 2024 22:16
shortcuts pushed a commit that referenced this pull request Mar 27, 2024
馃 I have created a release *beep* *boop*
---


##
[1.11.0](v1.10.2...v1.11.0)
(2024-03-27)


### Features

* **scratchPad:** provide `pathToFile` option
([#332](#332))
([9a8d96d](9a8d96d))


### Bug Fixes

* **autocmds:** better state check for scratchpads
([#327](#327))
([a54ffe9](a54ffe9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant