Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #131

Closed
rukai opened this issue Aug 9, 2021 · 3 comments · Fixed by #150 or #151
Closed

Update dependencies #131

rukai opened this issue Aug 9, 2021 · 3 comments · Fixed by #150 or #151
Assignees
Labels
good first issue Good for newcomers

Comments

@rukai
Copy link
Member

rukai commented Aug 9, 2021

Update dependencies to their latest versions.
e.g. I can see that the metrics dep is 0.12 but the latest is 0.17

Once the repo goes public we can track out of date dependencies on https://deps.rs/ but for now I think we just need to manually check the version ourselves.

@rukai rukai added the good first issue Good for newcomers label Aug 9, 2021
@Claudenw
Copy link
Contributor

Is there a reason not to use semantic numbering and just use ^0.12.0 as the value

@conorbros conorbros self-assigned this Aug 23, 2021
@conorbros conorbros added this to In progress in Open Sourcing Aug 24, 2021
@rukai
Copy link
Member Author

rukai commented Aug 24, 2021

as kuangda mentioned in #150 semver is the default.
The benefit for upgrading from 0.12 to 0.17 is to get access to new features and bug fixes in case we need them.

This issue was created as a good first issue as updating dependencies is an easy way to increase familiarity with a codebase without yet understanding the problem domain.

@conorbros conorbros linked a pull request Aug 24, 2021 that will close this issue
@conorbros conorbros moved this from In progress to Done in Open Sourcing Aug 24, 2021
@rukai
Copy link
Member Author

rukai commented Aug 24, 2021

We still have the dependencies that require code changes to go!

@rukai rukai reopened this Aug 24, 2021
@conorbros conorbros moved this from Done to In progress in Open Sourcing Aug 24, 2021
@conorbros conorbros linked a pull request Aug 27, 2021 that will close this issue
@rukai rukai moved this from In progress to Done in Open Sourcing Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Open Sourcing
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants