Avoid cloning prepared metadata fields #982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreparedMetadata contains a bunch of allocating fields we dont actually use like
col_specs
andglobal_table_spec.table_name
.So I created a cut down version of PreparedMetadata to save 2 clones of these unused allocations.
This saves ~0.5% in the flamegraph but this would have an even larger affect when the col_specs field has more complicated values in it.